Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simple_linear_regression] Review pandas code, update spelling (american), and misc edits #378

Merged
merged 7 commits into from
Feb 29, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Feb 20, 2024

This PR is part of the review of pandas code (#350) -- the pandas code in this lecture is pretty straight forward.

Additional things covered in this PR:

  • update and fix spelling (use american english)
  • update data location in exercises to fetch directly from github (rather than file based)

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit c8bc078
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/65d54ce711167c00082ce772
😎 Deploy Preview https://deploy-preview-378--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 20, 2024

@github-actions github-actions bot temporarily deployed to pull request February 20, 2024 06:01 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Feb 21, 2024

@jstac I am doing a review of the pandas based code but also touching up a few issues I see along the way.

Would you prefer full lecture reviews?

@mmcky
Copy link
Contributor Author

mmcky commented Feb 21, 2024

  • add numbered figures

@github-actions github-actions bot temporarily deployed to pull request February 21, 2024 00:47 Inactive
@jstac
Copy link
Contributor

jstac commented Feb 21, 2024

All reviews are greatly appreciated :-)

I'll leave you to it @mmcky , please merge when ready

@github-actions github-actions bot temporarily deployed to pull request February 21, 2024 01:16 Inactive
@mmcky mmcky added the ready label Feb 21, 2024
@mmcky mmcky merged commit 0bb0893 into main Feb 29, 2024
6 checks passed
@mmcky mmcky deleted the review-simple-linear-regression branch February 29, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants